[webkit-reviews] review requested: [Bug 27651] [Qt] QWebPluginDatabase API : [Attachment 34896] Add arePathsEqual() function to the FileSystem files.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 15 08:32:53 PDT 2009


Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 34896: Add arePathsEqual() function to the FileSystem files.
https://bugs.webkit.org/attachment.cgi?id=34896&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
(In reply to comment #33)
> (From update of attachment 33894 [details])
> This seems OK.  Maybe it should be called normalizePathForComparison if it's
> only for comparison.	It's unclear what "normalize" should actually do?  Does

> it resolve symlinks?	Does it remove traililing '/' chars?  Does it return
the
> ~1 windows form of paths?  r- for more explanation and or a better name...
> 
> In general I'm in favor of the concept though.  Another way would be to to
just
> have a arePathsEqual function. :)

I'm not so sure myself what normalizePath() should exactly do. :) Definitely
remove a trailing slash, strip trailing whitespaces, resolve relative subpaths
(e.g. /foo/bar/../baz)... Not necessarily resolve symbolic links. Not sure what
else and what directory separators it should use.

I gave the arePathsEqual() concept a try. It seems to be a good idea to leave
the comparison part up to the ports so they can decide what they should do
before comparing the strings.


More information about the webkit-reviews mailing list