[webkit-reviews] review granted: [Bug 27028] [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment 32560] cleanup. update patch to svn r45707

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 14 23:04:53 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has granted  review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32560: cleanup.  update patch to svn r45707
https://bugs.webkit.org/attachment.cgi?id=32560&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> -    if ((gint)info == WEBKIT_WEB_VIEW_TARGET_INFO_HTML) {
> +    if ((gint)info ==
Pasteboard::generalPasteboard()->m_helper->getWebViewTargetInfoHtml()) {
>	   gtk_selection_data_set(selection_data, selection_data->target, 8,
>				  reinterpret_cast<const
guchar*>(clipboardData->markup()),
>				  g_utf8_strlen(clipboardData->markup(), -1));

The braces should be removed as there's only one statement here.

I've looked into this again and seems I overlooked a few things in my review.
This patch is fine. r=me.


More information about the webkit-reviews mailing list