[webkit-reviews] review denied: [Bug 28304] S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite : [Attachment 34839] This is the patch to fix the bug.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 14 15:24:57 PDT 2009
Oliver Hunt <oliver at apple.com> has denied Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 28304: S60 Qt Webkit browser crashes while loading the V8 Benchmark Suite
https://bugs.webkit.org/show_bug.cgi?id=28304
Attachment 34839: This is the patch to fix the bug.
https://bugs.webkit.org/attachment.cgi?id=34839&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
The Interpreter should not have any platform specific code in it.
In general if your patch adds #if PLATFORM(...) to code where there are no
existing PLATFORM specific #ifs, your patch is wrong.
I'm also unsure why you feel the need to do this here -- there are plenty of
places where you can just check for malloc failure and convert to a JS OOM
exception.
More information about the webkit-reviews
mailing list