[webkit-reviews] review granted: [Bug 23642] [GTK] Drag and drop support : [Attachment 34659] Third patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 23642: [GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Attachment 34659: Third patch
https://bugs.webkit.org/attachment.cgi?id=34659&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +	   gchar* data;
> +	   switch (contents_request->info) {
> +	   case WEBKIT_WEB_VIEW_TARGET_INFO_URI_LIST:
> +	       data = g_strdup_printf("%s\r\n%s\r\n", contents_request->url,
url_label);
> +	   case WEBKIT_WEB_VIEW_TARGET_INFO_NETSCAPE_URL:
> +	       data = g_strdup_printf("%s\n%s", contents_request->url,
url_label);
> +	   }
> +

You are missing the breaks. Or at least one. =)

> +    switch (contents_request->info) {
> +    case WEBKIT_WEB_VIEW_TARGET_INFO_HTML:
> +    case WEBKIT_WEB_VIEW_TARGET_INFO_TEXT:
> +	   {

I don't think we want a { here. I don't see a need to limit the scope, so I am
not sure why you chose to do it.

I will say r=me, but we need these fixed before we commit.