[webkit-reviews] review denied: [Bug 28133] SVG Filter feBlend implementation missing : [Attachment 34689] SVG Filter feBlend Implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 14:28:00 PDT 2009


Oliver Hunt <oliver at apple.com> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 28133: SVG Filter feBlend implementation missing
https://bugs.webkit.org/show_bug.cgi?id=28133

Attachment 34689: SVG Filter feBlend Implementation
https://bugs.webkit.org/attachment.cgi?id=34689&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
You may as well add unchecked get functions to ByteArray, eg.
unsigned char ByteArray::get(int index) {
    ASSERT(index<size);
    return data[index];
}

You also don't need to update CanvasPixelArray -- just the underlying bytearray
implementation.


More information about the webkit-reviews mailing list