[webkit-reviews] review granted: [Bug 28243] JavaScriptCore tweaks to get ready for the parser arena : [Attachment 34775] patch addressing David Levin’s comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 14:11:58 PDT 2009

David Levin <levin at chromium.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 28243: JavaScriptCore tweaks to get ready for the parser arena

Attachment 34775: patch addressing David Levin’s comments

------- Additional Comments from David Levin <levin at chromium.org>
Thanks for the explanations for "It is not obvious to me why function->body()
cannot be 0 here."

Looks great. One thing to fix on landing.

> Index: JavaScriptCore/parser/Lexer.h
> +	   bool scanRegExp(const Identifier*& pattern, const Identifier*&
flags, UChar prefix = 0);


fwiw, this will break the windows build when it lands because
will need changes similar to what you did for JavaScriptCore.exp but a lot of
times people seem to land things 
and then figure out the appropriate name mangling from buildbot and then fix
these up.

More information about the webkit-reviews mailing list