[webkit-reviews] review requested: [Bug 27944] Geolocation error callback not called if permissions have already been denied : [Attachment 34779] Patch 1 for bug 27944

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 13:38:41 PDT 2009


steveblock at google.com has asked  for review:
Bug 27944: Geolocation error callback not called if permissions have already
been denied
https://bugs.webkit.org/show_bug.cgi?id=27944

Attachment 34779: Patch 1 for bug 27944
https://bugs.webkit.org/attachment.cgi?id=34779&action=review

------- Additional Comments from steveblock at google.com
When a Geolocation method is called, immediately calls the error callback
asynchronously if permissions have already been denied.

Note that the naming of the new 'setFatalError' and 'fatalErrorOccurred'
methods is intentionally generic. This is because this framework will be used
for other fatal error conditions. Currently, if the Geolocation service fails
to start, the error callback is invoked synchronously. This is incorrect. See
Bug 28276. This framework will be used to fix this behavior also.

LayoutTests for this behavior will be added once the mock Geolocation service
framework is in place. See Bug 28264.


More information about the webkit-reviews mailing list