[webkit-reviews] review requested: [Bug 28265] Fix off-by-one result comparisons in media tests on Windows Debug builds : [Attachment 34755] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 13 10:10:56 PDT 2009
Adam Roben (aroben) <aroben at apple.com> has asked for review:
Bug 28265: Fix off-by-one result comparisons in media tests on Windows Debug
builds
https://bugs.webkit.org/show_bug.cgi?id=28265
Attachment 34755: Patch v1
https://bugs.webkit.org/attachment.cgi?id=34755&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
media/video-played.html seems always to time out in Windows Debug
builds. A race condition between media/video-test.js's "hang" timer and
DumpRenderTree's built-in "watchdog" timer was causing results for
media/video-played.html to be printed twice, causing all future media
tests to be compared to the previous test's results.
The fix is to get rid of video-test.js's hang timer, since it is
redundant given the existence of DRT's watchdog timer.
Reviewed by NOBODY (OOPS!).
Need a short description and bug URL (OOPS!)
* media/video-test.js: Remove the hang timer, since DRT does the same
thing.
---
2 files changed, 21 insertions(+), 8 deletions(-)
More information about the webkit-reviews
mailing list