[webkit-reviews] review denied: [Bug 28240] [Qt] Allow applications to register their own local URL scheme : [Attachment 34709] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 28240: [Qt] Allow applications to register their own local URL scheme
https://bugs.webkit.org/show_bug.cgi?id=28240

Attachment 34709: Patch
https://bugs.webkit.org/attachment.cgi?id=34709&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I agree with the need for this API, but I have a few suggestions and comments
for the implementation:


> +/*!
> +    Allow applications to use a custome scheme instead of file: scheme,
> +    without being subjected to cross domain restrictions.
> +*/
> +void QWebSecurityOrigin::addLocalScheme(QString& scheme)

The QString argument should be a const QString &, not a QString &.


I think we may also need a function to remove a local scheme, i.e.

void removeLocalScheme(const QString &scheme);

as well as a function to return a list of all known local schemes:

QStringList QWebSecurityOrigin::localSchemes();