[webkit-reviews] review denied: [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage : [Attachment 34538] 4th try.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 28036: [Qt] Public API to configure the storage path for HTML5 localStorage
https://bugs.webkit.org/show_bug.cgi?id=28036

Attachment 34538: 4th try.
https://bugs.webkit.org/attachment.cgi?id=34538&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r- as discussed.

It would be best to have one isolated patch that

1) Fixes the naming of the enum
2) and introduces the storage path without any defaults or without enabling it
by default.

> @@ -62,7 +62,10 @@ public:
>	   PrintElementBackgrounds,
>	   OfflineStorageDatabaseEnabled,
>	   OfflineWebApplicationCacheEnabled,
> +#ifdef QT_DEPRECATED
>	   LocalStorageDatabaseEnabled,
> +#endif
> +	   LocalStorageEnabled,
>	   LocalContentCanAccessRemoteUrls
>      };

A slighty more backwards-compatible way of deprecating the old value would be
to use the following notation:

enum {
    ...
    LocalStorageEnabled,
#ifdef QT_DEPRECATED
    LocalStorageDatabaseEnabled = LocalStorageEnabled,
#endif