[webkit-reviews] review granted: [Bug 28177] WebInspector: Migrate to DOMAgent (serialized access to DOM) : [Attachment 34733] The patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 05:23:46 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 28177: WebInspector: Migrate to DOMAgent (serialized access to DOM)
https://bugs.webkit.org/show_bug.cgi?id=28177

Attachment 34733: The patch.
https://bugs.webkit.org/attachment.cgi?id=34733&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +		   case "Storage":
> +			   InspectorController.selectDOMStorage(o);
> +		       break;

Extra indent here.
> -    useDOMAgent: false
> +    useDOMAgent: true

Can this just be removed now?

> -    if (obj instanceof win.Node)
> +    if (obj instanceof win.Node && !(obj instanceof win.Document))

Does this still let console.dirxml(document) output the HTML tree?


More information about the webkit-reviews mailing list