[webkit-reviews] review denied: [Bug 27716] Add Geolocation layout tests. : [Attachment 34725] Disables Geolocation tests for GTK

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 02:49:59 PDT 2009


David Levin <levin at chromium.org> has denied steveblock at google.com's request for
review:
Bug 27716: Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716

Attachment 34725: Disables Geolocation tests for GTK
https://bugs.webkit.org/attachment.cgi?id=34725&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: LayoutTests/platform/gtk/Skipped
> @@ -5979,3 +5979,6 @@ editing/selection/find-in-text-control.h
>  fast/harness/override-preferences.html
>  fast/harness/override-preferences-2.html
>  fast/harness/override-zzz-reset.html
> +
> +# This port doesn't support Geolocation.
> +fast/dom/Geolocation

Two issues:
* According to comment at the top of the file: "no grouping should occur. Every
test for itself."

* This appears to be doing the addition in the section which is "# Tests with
bugs attached : Enable these tests again once these bugs are fixed." but this
failure doesn't fit in that category.


More information about the webkit-reviews mailing list