[webkit-reviews] review denied: [Bug 28235] Using QWebFrame::evaluateJavaScript does not relayout : [Attachment 34700] Patch to fix the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 02:02:05 PDT 2009

Simon Hausmann <hausmann at webkit.org> has denied  review:
Bug 28235: Using QWebFrame::evaluateJavaScript does not relayout

Attachment 34700: Patch to fix the bug

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
This patch is missing a ChangeLog.

I'm not convinced it's the correct fix though. Why do the other ports appear
not to need this?

For example the Mac API has stringByEvaluatingJavaScriptFromString, which can
be called to evaluate javascript and the view will be updated afterwards. (A
quick google search suggests that it works).

However I notice one important difference:

We are calling evaluate() on the ScriptController directly, whereas the mac
port calls FrameLoader::executeScript, which calls
Document::updateStyleForAllDocuments() after evaluation.

I think the correct fix involves calling executeScript instead of evaluate on
the ScriptController.

More information about the webkit-reviews mailing list