[webkit-reviews] review granted: [Bug 27966] Race condition in the database code : [Attachment 34701] patch + test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 12 16:25:20 PDT 2009


Eric Seidel <eric at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 27966: Race condition in the database code
https://bugs.webkit.org/show_bug.cgi?id=27966

Attachment 34701: patch + test case
https://bugs.webkit.org/attachment.cgi?id=34701&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Passing "read" or "write" instead of a bool would have made the callsites more
clear, but this is OK as is.

28 function statementSuccessCallback(dbName, isReadStatement)
 29 {
 30	log(dbName + " " + (isReadStatement ? "read" : "write") + " statement
succeeded");
 31 }
 32 
 33 function statementErrorCallback(dbName, isReadStatement, error)


More information about the webkit-reviews mailing list