[webkit-reviews] review denied: [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP : [Attachment 34648] resubmit the patch to address comments

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied  review:
Bug 23727: Implementaion of WCSS marquee extension relevant to XHML MP
https://bugs.webkit.org/show_bug.cgi?id=23727

Attachment 34648: resubmit the patch to address comments
https://bugs.webkit.org/attachment.cgi?id=34648&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

 157	 if (m_layer->renderer()->document()->isXHTMLMPDocument()) {
 158	     if (m_timer.isActive() ||
m_layer->renderer()->style()->marqueeIncrement().isZero() ||
!m_layer->renderer()->style()->marqueeLoopCount())    
 159		 return;
 160	 } else {
 161	     if (m_timer.isActive() ||
m_layer->renderer()->style()->marqueeIncrement().isZero())
 162		 return;
 163	 }
 164	 

I would have written that as:

161	    if (m_timer.isActive() ||
m_layer->renderer()->style()->marqueeIncrement().isZero() ||
(m_layer->renderer()->document()->isXHTMLMPDocument() &&
!m_layer->renderer()->style()->marqueeLoopCount())
 162		 return;

in fact, that can seasily just be added as part of the existing if:

     if (m_timer.isActive() ||
m_layer->renderer()->style()->marqueeIncrement().isZero()
#if WCSS
|| (m_layer->renderer()->document()->isXHTMLMPDocument() &&
!m_layer->renderer()->style()->marqueeLoopCount()
#endif
}
156167	       return;