[webkit-reviews] review granted: [Bug 28185] Inspector: Show Hidden Cookie Data : [Attachment 34692] Improved Based on Review - expires as epoch double

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 12 14:38:53 PDT 2009


Darin Adler <darin at apple.com> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 28185: Inspector: Show Hidden Cookie Data
https://bugs.webkit.org/show_bug.cgi?id=28185

Attachment 34692: Improved Based on Review - expires as epoch double
https://bugs.webkit.org/attachment.cgi?id=34692&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   NSTimeInterval expires = [[cookie expiresDate]
timeIntervalSince1970] * 1000;

I'd say double here since this isn't really an NSTimeInterval since it's not in
the standard units for NSTimeInterval.

r=me


More information about the webkit-reviews mailing list