[webkit-reviews] review requested: [Bug 27060] Type cast for first argument in make_pair() : [Attachment 34683] Updated patch for bug #27060

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 12 13:18:26 PDT 2009

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27060: Type cast for first argument in make_pair()

Attachment 34683: Updated patch for bug #27060

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
Symbian compiler for emulator target (WINSCW) fails with "illegal operand" for
m_attributesInPrevious in structure.ccp (when calling make_pair functions).
This error is apparently due to the compiler not properly resolving the
unsigned type of the declared bitfield.

Initial patch explicitly casted m_attributesInPrevious to unsigned (at 3 places
in structure.cpp), but since bitfield optimization is not critical for the
emulator target, this conditional change in header file appears to be least

More information about the webkit-reviews mailing list