[webkit-reviews] review denied: [Bug 28126] [Haiku] Adding SharedTimer to WebCore. : [Attachment 34663] Patch to add the SharedTimer file for Haiku.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28126: [Haiku] Adding SharedTimer to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28126

Attachment 34663: Patch to add the SharedTimer file for Haiku.
https://bugs.webkit.org/attachment.cgi?id=34663&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
+    bigtime_t interval = fireTime - currentTime();
+
+    if (interval < 0)
+	 interval = 0;
+    else
+	 interval *= 1000;

Should be something like:

bigtime_t millisecondInterval = fireTime - currentTime();
bigtime_t secondInterval = std::max(0, millisecondInterval * 1000);

Important to make the variable names clear as to what they're holding.

Otherwise looks fine.