[webkit-reviews] review granted: [Bug 28185] Inspector: Show Hidden Cookie Data : [Attachment 34660] Improved Based on Review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 12 09:17:34 PDT 2009

Darin Adler <darin at apple.com> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 28185: Inspector: Show Hidden Cookie Data

Attachment 34660: Improved Based on Review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   cookieObject->putDirect(sizeIdentifier, jsNumber(exec,

I'm so sorry I didn't mention this earlier. It seems clear to me that if "size"
is just name.length() + value.length() then it should not be stored in a Cookie
struct. Instead it should be computed, perhaps in JavaScript code, or perhaps
in this function, or perhaps in a function member of the Cookie struct.

Another possibility is that this "name.length() + value.length()" computation
is just an estimate that's being used because the cookie API on Mac OS X does
not supply the length. In that case, the logic to compute this size estimate
should be in the getRawCookies function in CookieJarMac.mm, not in the
cross-platform code, and the size should be a constructor argument.

Everything else is perfect, and this is a minor issue.


More information about the webkit-reviews mailing list