[webkit-reviews] review requested: [Bug 23727] Implementaion of WCSS marquee extension relevant to XHML MP : [Attachment 34648] resubmit the patch to address comments

[bugzilla-daemon at webkit.org]

Charles Wei <charles.wei at torchmobile.com.cn> has asked Nikolas Zimmermann
<zimmermann at kde.org> for review:
Bug 23727: Implementaion of WCSS marquee extension relevant to XHML MP
https://bugs.webkit.org/show_bug.cgi?id=23727

Attachment 34648: resubmit the patch to address comments
https://bugs.webkit.org/attachment.cgi?id=34648&action=review

------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
This patch differes from the patch submitted on Aug 8 , 2009 is that :

For the changes for RenderMarquee,  it only applys when the WCSS and XHTMLMP
are enabled, and the document is of XHTMLMP type,  no impacts to the HTML
documents. 

For the other comment from Niko to have a .css file to replace the hard-coded
codes that initializes the marquee status with :

*[display="-wap-marquee"] {overflow=...}

Actually this doesn't work. The above universal selector works for something
like display as an attribute like:

<a display="-wap-marquee">

There's no such an attribute for HTML/xHTML tags,  actually the WCSS marquee is
an extension to WCSS display and it works like this : 

<a href="..."
style="display:-wap-marquee;-wap-marquee-loop:xxx;-wap-marquee-dir:xxx;-wap-mar
quee-style:xxx;-wap-marquee-speed:xxx">

So the universal selector  *[display="-wap-marquee"] {...} doesn't work.