[webkit-reviews] review requested: [Bug 28173] [GTK] Remove keyring optional features : [Attachment 34643] removekeyringv3.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 12 00:44:42 PDT 2009

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 28173: [GTK] Remove keyring optional features

Attachment 34643: removekeyringv3.patch

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Updated patch.

- Fixes style issues.
- Updates the check of the HTTP status code per danw's suggestion.
- Only shows the 'save passwords' option if the session has a password manager
- I couldn't figure out a way of refactor response_callback to not have a
boolean freeAuthData without either duplicating code or adding a goto...
suggestions welcome.

More information about the webkit-reviews mailing list