[webkit-reviews] review denied: [Bug 28168] commit-log-editor does not support all the email config that prepare-Changelog supports : [Attachment 34528] commit-log-editor does not support all the email config that prepare-Changelog supports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 22:31:18 PDT 2009


Eric Seidel <eric at webkit.org> has denied Pierre d'Herbemont
<pdherbemont at webkit.org>'s request for review:
Bug 28168: commit-log-editor does not support all the email config that
prepare-Changelog supports
https://bugs.webkit.org/show_bug.cgi?id=28168

Attachment 34528: commit-log-editor does not support all the email config that
prepare-Changelog supports
https://bugs.webkit.org/attachment.cgi?id=34528&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Should this be an empty return as such?
 224	 return unless $isGit;
not '' ?

Style:
229	if (exitStatus($?) != 0) {
 230	     $result = `git repo-config $config`;
 231	 }

Shouldn't you move the user.name stuff into webkitdirs.pm too?

Seems we should be splitting some of this stuff out into separate modules from
webkitdirs.pm anyway...

And geeeez we need to move commit-log-editor to python. :(

r- for the style nits.	Consider breaking these out of this huge (poorly named)
module.


More information about the webkit-reviews mailing list