[webkit-reviews] review granted: [Bug 27965] ImageSourceFoo.cpp contains lots of Copy+Paste code and should be refactored : [Attachment 34625] Merge in ImageSourceSkia.cpp

[bugzilla-daemon at webkit.org]

Adam Treat <treat at kde.org> has granted Peter Kasting <pkasting at google.com>'s
request for review:
Bug 27965: ImageSourceFoo.cpp contains lots of Copy+Paste code and should be
refactored
https://bugs.webkit.org/show_bug.cgi?id=27965

Attachment 34625: Merge in ImageSourceSkia.cpp
https://bugs.webkit.org/attachment.cgi?id=34625&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> -
> -    return m_decoder->frameBufferAtIndex(index)->hasAlpha();
> +    // When a frame has not finished decoding, always mark it as having
alpha.
> +    // Ports that check the result of this function to determine their
> +    // compositing op need this in order to not draw the undecoded portion
as
> +    // black.
> +    // TODO: Perhaps we should ensure that each individual decoder returns
true
> +    // in this case.
> +  return frameIsCompleteAtIndex(index) ?
> +	 m_decoder->frameBufferAtIndex(index)->hasAlpha() : true;

Looks like an indentation problem.  Otherwise looks good!  r+ and you can fix
indentation on landing.