[webkit-reviews] review granted: [Bug 28204] Not possible to build WebCore+V8 with -fno-exceptions on Mac : [Attachment 34623] Only undefine |try| and |catch| when building Objective-C[++]

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mark Mentovai <mark at chromium.org>'s
request for review:
Bug 28204: Not possible to build WebCore+V8 with -fno-exceptions on Mac
https://bugs.webkit.org/show_bug.cgi?id=28204

Attachment 34623: Only undefine |try| and |catch| when building Objective-C[++]
https://bugs.webkit.org/attachment.cgi?id=34623&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +/* When C++ exceptions are disabled, the C++ STL defines |try| and |catch|
to
> + * allow C++ code that expects exceptions to build.	These definitions

We use one space after a period, not two. It would be nice to have your comment
follow that rule.

I think the use of the term STL in this comment is a little dated. That's
really not the name for it any more.

This is definitely a bug in the C++ library, but one that the folks who
maintain it have declined to fix.