[webkit-reviews] review requested: [Bug 28187] "Double-click to add" new style button does not always show up : [Attachment 34597] Quick Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 14:49:00 PDT 2009

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 28187: "Double-click to add" new style button does not always show up

Attachment 34597: Quick Fix

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This is the quick fix for the Nightly Build.


I think a more optimal solution would be to avoid throwing an error at all.
Instead something like WebInspector.Color.parseColor() factory method which
would return either 'null' or a WebInspector.Color object.  That way we won't
have to worry about any throw/catch.  Along with the other improvements
mentioned previously, including:

  - swatch shows up accidentally
  - all swatches should be clickable to toggle colors
  - swatches should be clickable in shorthand properties

More information about the webkit-reviews mailing list