[webkit-reviews] review requested: [Bug 27965] ImageSourceFoo.cpp contains lots of Copy+Paste code and should be refactored : [Attachment 34586] Move ImageSourceCairo.cpp to ImageSource.cpp

[bugzilla-daemon at webkit.org]

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 27965: ImageSourceFoo.cpp contains lots of Copy+Paste code and should be
refactored
https://bugs.webkit.org/show_bug.cgi?id=27965

Attachment 34586: Move ImageSourceCairo.cpp to ImageSource.cpp
https://bugs.webkit.org/attachment.cgi?id=34586&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This moves ImageSourceCairo.cpp to ImageSource.cpp.

There are a couple questionable bits here:

* I have excluded ImageSource.cpp from the WebKit Windows CG builds, like the
old ImageSourceCairo.cpp was.  Perhaps instead I should have included it but
put a "!PLATFORM(CG)" atop it?	It seems uncommon to exclude "cross-platform"
files from the Windows CG build...

* I removed "#include <cairo.h>".  The only potential use is for the
NativeImagePtr return type from createFrameAtIndex().  Since this is being
returned directly from another function, I don't think the compiler actually
needs the underlying type here.  At least for Skia this type of change compiles
(I tried removing "#include SkBitmap.h" from ImageSourceSkia.cpp and building);
I'd like to be able to test whether it works on Cairo too.  If so, it means we
can avoid pulling in any platform-specific headers, which would be great.