[webkit-reviews] review denied: [Bug 27980] Give an ability to WebKit to free statically allocated pointers before quit : [Attachment 34549] Fourth patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 27980: Give an ability to WebKit to free statically allocated pointers
before quit
https://bugs.webkit.org/show_bug.cgi?id=27980

Attachment 34549: Fourth patch
https://bugs.webkit.org/attachment.cgi?id=34549&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#include "wtf/StaticPtr.h"

Includes of wtf from WebCore use angle brackets. <wtf/StaticPtr.h>, not
"wtf/StaticPtr.h".

> +static WTF::StaticPtr<JSGlobalData> sharedInstancePtr;

This won't work with the restrictions we need to work as a Mac OS X framework.
We can't have any static destructors in our Mac OS X system frameworks as a
matter of policy to make process exit fast. No objects with destructors as
globals or statics. That's the reason for the DEFINE_STATIC_LOCAL macro.

A major reason this patch is unacceptable is that this creates many global
objects with destructors.

I didn't review further because that's a major problem with the current
version.