[webkit-reviews] review requested: [Bug 28177] WebInspector: Migrate to DOMAgent (serialized access to DOM) : [Attachment 34565] Step1: Most of the work done. Call for your comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 09:13:10 PDT 2009


Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 28177: WebInspector: Migrate to DOMAgent (serialized access to DOM)
https://bugs.webkit.org/show_bug.cgi?id=28177

Attachment 34565: Step1: Most of the work done. Call for your comments.
https://bugs.webkit.org/attachment.cgi?id=34565&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
The general idea of this patch is that we stop pushing live objects into the
frontend upon evaluation and console.dir requests. It also migrates to
WebInspector.DOMAgent.

Patch is not complete: 
- it does not implement DOM search
- it breaks commandLineAPI's inspect(o).

But it already has a lot of changes and I would like to get initial feedback on
it.
I am fixing the ones above in the meanwhile.

What will happen after this change:
- More bugfixes if I miss anything
- Move search worker into the InjectedScript
- Look at debugging, database and the rest of the places that still push live
objects into the frontend
- Move InjectedScript into the isolated context and get rid of all the
"quarantine*" calls and support.


More information about the webkit-reviews mailing list