[webkit-reviews] review requested: [Bug 24986] [multi-patch] ARM JIT port : [Attachment 34560] Add optimize call and property access support for ARM JIT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 11 08:22:21 PDT 2009


Gabor Loki <loki at inf.u-szeged.hu> has asked  for review:
Bug 24986: [multi-patch] ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 34560: Add optimize call and property access support for ARM JIT
https://bugs.webkit.org/attachment.cgi?id=34560&action=review

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
I have done the requested changes from comment #93.

- The 'latePatch' method is removed.
    It looks like that forcing the address of calls on constant pool does not
hurt much. Wash on SunSpider (slightly slower but not statistically
significant).

- The {BEGIN,END}_UNINTERRUPTED_SEQUENCE macros have been introduced for
tightly coupled sequences.
    I try to keep the code as platform independent as possible.

- The optimize call and property access patches are combined.


More information about the webkit-reviews mailing list