[webkit-reviews] review granted: [Bug 28134] Move Access Control out of XMLHttpRequest : [Attachment 34531] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 21:15:40 PDT 2009

Alexey Proskuryakov <ap at webkit.org> has granted Aaron Boodman
<aa at chromium.org>'s request for review:
Bug 28134: Move Access Control out of XMLHttpRequest

Attachment 34531: New patch

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +	 ThreadableLoaderOptions() : sendLoadCallbacks(false),
sniffContent(false), crossOriginAccessControl(false), allowCredentials(false),
forceCrossOriginPreflight(false), allowCrossOriginRedirect(false) {}

We usually put a space between braces in such cases.

> +    // Note: the loader will be deleted as soon as this function exits.

Most comments are also notes :)

r=me, thanks!

More information about the webkit-reviews mailing list