[webkit-reviews] review requested: [Bug 27323] Better support for non-Cygwin SVN on Windows : [Attachment 34526] Even more line-ending-stripping for auto-version.sh

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 16:19:08 PDT 2009


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 34526: Even more line-ending-stripping for auto-version.sh
https://bugs.webkit.org/attachment.cgi?id=34526&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
I got jessieberlin to send me the (broken) autoversion.h generated in her
checkout with the PATH patch on this bug applied.  Lo and behold $(whoami) was
returning a value with a trailing CR!  So strip line endings from $(whoami) and
$(date), too.


More information about the webkit-reviews mailing list