[webkit-reviews] review denied: [Bug 27719] [Chromium] Regression in r42671 - js event object being hidden. : [Attachment 34499] patch - Add a DOMWindowEvent CustomSetter to V8DOMWindowCustom.cpp

Mon Aug 10 12:56:07 PDT 2009

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27719: [Chromium] Regression in r42671 - js event object being hidden.
https://bugs.webkit.org/show_bug.cgi?id=27719

Attachment 34499: patch - Add a DOMWindowEvent CustomSetter to
V8DOMWindowCustom.cpp
https://bugs.webkit.org/attachment.cgi?id=34499&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
>  
> -	   attribute [Replaceable, CustomGetter] Event event;
> +	   attribute [Custom] Event event;

This will break JSC build. Let's just add V8CustomSetter instead.

> +	   * fast/events/manually-nulled-event-expected.txt: Added.
> +	   * fast/events/manually-nulled-event.html: Added.

Yucky name. How about setting-event-to-null.html?

> +<script language="javascript">

I would rather see this code in <head> element, initiated by body
onload="runTest();"

> +layoutTestController.dumpAsText();

need to check for layoutTestController existence:

if (window.layoutTestController)

> +
> +</script>
> +</body</html>