[webkit-reviews] review requested: [Bug 28157] Fix linker warnings about multiply-defined JSMedia symbols on Windows : [Attachment 34491] Post the right patch this time.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 11:40:36 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has asked  for review:
Bug 28157: Fix linker warnings about multiply-defined JSMedia symbols on
Windows
https://bugs.webkit.org/show_bug.cgi?id=28157

Attachment 34491: Post the right patch this time.
https://bugs.webkit.org/attachment.cgi?id=34491&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
This fixes some compiler warnings.

Reviewed by NOBODY (OOPS!).

Need a short description and bug URL (OOPS!)

* WebCore.vcproj/WebCore.vcproj: Excluded JSMedia.cpp from the build,
as it is also listed in DerivedSources.cpp. This is what we do for the
other generated .cpp files. Also let VS reorder the file list as it
saw fit.
---
 2 files changed, 77 insertions(+), 22 deletions(-)


More information about the webkit-reviews mailing list