[webkit-reviews] review denied: [Bug 27842] Implement GraphicsContext::fillRoundRect() for WINCE port : [Attachment 34484] Add update to .h file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 11:31:40 PDT 2009


George Staikos <staikos at kde.org> has denied  review:
Bug 27842: Implement GraphicsContext::fillRoundRect() for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27842

Attachment 34484: Add update to .h file
https://bugs.webkit.org/attachment.cgi?id=34484&action=review

------- Additional Comments from George Staikos <staikos at kde.org>

> --- a/WebCore/platform/graphics/GraphicsContext.h
> +++ b/WebCore/platform/graphics/GraphicsContext.h
> @@ -221,6 +221,8 @@ namespace WebCore {
>	   void fillRect(const FloatRect&, Generator&);
>	   void fillRoundedRect(const IntRect&, const IntSize& topLeft, const
IntSize& topRight, const IntSize& bottomLeft, const IntSize& bottomRight, const
Color&);
>  
> +	   void drawRoundCorner(bool newClip, RECT clipRect, RECT rectWin, HDC
dc, int width, int height);
> +
>	   void clearRect(const FloatRect&);
>  
>	   void strokeRect(const FloatRect&);

That should be in a PLATFORM(WINCE) place or it will break the build for
others.


More information about the webkit-reviews mailing list