[webkit-reviews] review granted: [Bug 28048] Place More WinCairo Settings in vsprop files : [Attachment 34483] Move some settings into WinCairo/cURL vsprops files.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 10 11:01:53 PDT 2009
Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 28048: Place More WinCairo Settings in vsprop files
https://bugs.webkit.org/show_bug.cgi?id=28048
Attachment 34483: Move some settings into WinCairo/cURL vsprops files.
https://bugs.webkit.org/attachment.cgi?id=34483&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> + * WebKit.vcproj/WebKit.vcproj: Add vsprops settings, and remove
> + manual flags and library dependencies for WinCairo port.
I think a little more detail would be preferable here, given the difficulty of
reading .vcproj diffs.
> - ForcedIncludeFiles="WebKitPrefix.h"
> DisableSpecificWarnings="4819"
> + ForcedIncludeFiles="WebKitPrefix.h"
I'm surprised by this change.
r=me
More information about the webkit-reviews
mailing list