[webkit-reviews] review granted: [Bug 28144] Memory leak in error handling code for SOUP interface : [Attachment 34449] Added "g_free" after calls to "soup_uri_to_string" and "g_file_get_uri" where they where missing.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 10 10:19:24 PDT 2009
Darin Adler <darin at apple.com> has granted John Kjellberg
<john.kjellberg at power.alstom.com>'s request for review:
Bug 28144: Memory leak in error handling code for SOUP interface
https://bugs.webkit.org/show_bug.cgi?id=28144
Attachment 34449: Added "g_free" after calls to "soup_uri_to_string" and
"g_file_get_uri" where they where missing.
https://bugs.webkit.org/attachment.cgi?id=34449&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + char *uri=soup_uri_to_string(soup_message_get_uri(msg), false);
Formatting is wrong here. It should be "char* uri = soup…"
Otherwise, this patch looks great. I'm going to say r=me
More information about the webkit-reviews
mailing list