[webkit-reviews] review granted: [Bug 20534] DumpRenderTree needs a way to override settings on a per-test basis : [Attachment 33995] Same patch with ChangeLog files updated and GTK and Wx changes.

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 33995: Same patch with ChangeLog files updated and GTK and Wx
changes.
https://bugs.webkit.org/attachment.cgi?id=33995&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Sorry for the long delay in reviewing this -- I was away on vacation.

The new tests are missing spaces between "if" and "(", and around "=", in a few
places.

> +++ b/WebKitTools/DumpRenderTree/LayoutTestController.h
> @@ -52,6 +52,7 @@ public:
>      bool isCommandEnabled(JSStringRef name);
>      void keepWebHistory();
>      void notifyDone();
> +    void overridePreference(JSStringRef key, JSStringRef flag);

I think "value" would be a clearer name for the second parameter.

r=me