[webkit-reviews] review denied: [Bug 28063] LayoutTests/http/tests/appcache/max-size.html fails - vacuum should happen after setting max size : [Attachment 34360] Patch with more helpful Changelog entries

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Martin Robinson
<martin.james.robinson at gmail.com>'s request for review:
Bug 28063: LayoutTests/http/tests/appcache/max-size.html fails - vacuum should
happen after setting max size
https://bugs.webkit.org/show_bug.cgi?id=28063

Attachment 34360: Patch with more helpful Changelog entries
https://bugs.webkit.org/attachment.cgi?id=34360&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Ok.  So this looks fine.  Need one more round though.

We need a comment next to the code noting that the order is important.	The
ChangeLog (and possibly the code comment) should ideally reference the SQLite
docs which say that order matters here.

Again, the change looks totally fine.  The point I'm going for is that we
should make sure that we make sure that no one will get this wrong again. :)
(When they re-factor the code for instance.)

If you were a committer, I would just r+ this and you could fix it when you
land.  Since you aren't, i'm going to ask that you post one more patch.

Thanks again for the patch!