[webkit-reviews] review requested: [Bug 28124] Web Inspector: Make all status bar button images glyph-based. : [Attachment 34438] patch (git binary diff format)

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 28124: Web Inspector: Make all status bar button images glyph-based.
https://bugs.webkit.org/show_bug.cgi?id=28124

Attachment 34438: patch (git binary diff format)
https://bugs.webkit.org/attachment.cgi?id=34438&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
>> Can't you just make the button's container position: relative? Thats what I
did in my sample.

I missed it, yes, it does work.

>> I think if you make button.status-bar-item position: relative you wont need
the
extra container. The CSS file had tbas in it also.

Done.

>> That sounds/looks like a bug with CSS masks that you should file, it looks
like
the mask is being iverted…

Once this is submitted, I will create another bug and attach a small glyph to
it so that one could reproduce it.
I will store small glyphs in the meanwhile so that we can use them later.