[webkit-reviews] review denied: [Bug 28132] FrameLoadType / WebFrameLoadType enums are out of sync : [Attachment 34425] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 9 13:52:47 PDT 2009


Maciej Stachowiak <mjs at apple.com> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 28132: FrameLoadType / WebFrameLoadType enums are out of sync
https://bugs.webkit.org/show_bug.cgi?id=28132

Attachment 34425: Initial patch
https://bugs.webkit.org/attachment.cgi?id=34425&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
This changes public API headers and may break source and/or binary compat. The
better way to do this would be to restore the old value to FrameLoadType, even
though it is unused. As discussed on IRC. r- for now, awaiting new patch.


More information about the webkit-reviews mailing list