[webkit-reviews] review denied: [Bug 28128] [Haiku] Modifications on WebCore. : [Attachment 34418] Patch to add modifications to the WebCore/platform/ files to allow the Haiku port.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 9 08:19:53 PDT 2009
Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28128: [Haiku] Modifications on WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28128
Attachment 34418: Patch to add modifications to the WebCore/platform/ files to
allow the Haiku port.
https://bugs.webkit.org/attachment.cgi?id=34418&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
What is:
85 BPoint m_point;
here? Is it the top-left of the menu? Is it the click-point? Seems it needs
a better member name.
Otherwise this change looks fine. r- for lack of useful name or explanation
for m_point. If you were a committer I would just ask you to rename it to
something when you landed it instead of r-ing.
More information about the webkit-reviews
mailing list