[webkit-reviews] review denied: [Bug 28126] [Haiku] Adding SharedTimer to WebCore. : [Attachment 34412] Patch to add the SharedTimer files for Haiku.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28126: [Haiku] Adding SharedTimer to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28126

Attachment 34412: Patch to add the SharedTimer files for Haiku.
https://bugs.webkit.org/attachment.cgi?id=34412&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The compiler won't read your comments. :)
 // Static instance
 88 SharedTimerHaiku* getSharedTimerHaiku()
you want that to say:
static SharedTimerHaiku* sharedTimerHaiku()
(we don't tend to use "get" in function names in WebCore.)

Oh, maybe you don't want it static...  Why is this needed outside of this
function?
 52	SharedTimerHaiku* getSharedTimerHaiku();

Also, why doesn't SharedTimerHaiku implement SharedTimer?

Why does SharedTimerHaiku need to *be* a BMessageFilter, can't it just have a
BMessageFilter member if necessary?

r- because I'm not sure why you needed to diverge from other SharedTimer
implementations here.