[webkit-reviews] review denied: [Bug 28121] [Haiku] Modifications on JavaScriptCore. : [Attachment 34406] Modifications on JavaScriptCore to allow Haiku port.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 9 07:39:28 PDT 2009

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28121: [Haiku] Modifications on JavaScriptCore.

Attachment 34406: Modifications on JavaScriptCore to allow Haiku port.

------- Additional Comments from Eric Seidel <eric at webkit.org>
Bah!  We need to abstract the Collector to use some sort of Threading*

This is the 3rd patch I've reviewed this week to add #ifdefs there. :(

+#include "platform/NotImplemented.h"

should be "NotImplemented.h" no need for "platform/"

r- for the wrong include path.	If you'd be kind enough to fix the threading
abstraction in some way (e.g. to at least use a static inline function for the
Haiku case that would be nice.)

More information about the webkit-reviews mailing list