[webkit-reviews] review canceled: [Bug 28124] Web Inspector: Make all status bar button images glyph-based. : [Attachment 34413] patch (git binary diff format)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 9 05:40:27 PDT 2009
Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 28124: Web Inspector: Make all status bar button images glyph-based.
https://bugs.webkit.org/show_bug.cgi?id=28124
Attachment 34413: patch (git binary diff format)
https://bugs.webkit.org/attachment.cgi?id=34413&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Note that I could not make it work as
<button>
<div class="glyph"></div>
<div class="glyph shadow"></div>
</button>
since glyph divs were positioned absolutely with respect to button's container
(that is a div with display:inline-block).
I ended up with
<button>
<div style="position:relative">
<div class="glyph"></div>
<div class="glyph shadow"></div>
</div>
</button>
and I am open to the hints / suggestions.
More information about the webkit-reviews
mailing list