[webkit-reviews] review granted: [Bug 28114] [ES5] Implement Object.getPrototypeOf : [Attachment 34399] Patch v1

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 28114: [ES5] Implement Object.getPrototypeOf
https://bugs.webkit.org/show_bug.cgi?id=28114

Attachment 34399: Patch v1
https://bugs.webkit.org/attachment.cgi?id=34399&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Do we want to guard this in any way?  I don't know how up-in-the-air ES5 is at
this point.

Technically this looks fine.

I guess isPrototypeOf was implemented before but just not well tested? (Since I
don't see the implementation of isPrototypeOf here.

Since this technically looks fine, and I trust you to make a guarding decision,
r+. :)	(I even went and read the spec.)

You might consider adding the spec text to your ChangeLog:

15.2.3.2 Object.getPrototypeOf ( O ) 
When the getPrototypeOf function is called with argument O, the following steps
are taken: 
1. If Type(O) is not Object throw a TypeError exception. 
2. Return the value of the [[Prototype]] internal property of O.