[webkit-reviews] review granted: [Bug 27716] Add Geolocation layout tests. : [Attachment 34402] Patch 4 for bug 27716
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Aug 8 15:29:05 PDT 2009
Eric Seidel <eric at webkit.org> has granted steveblock at google.com's request for
review:
Bug 27716: Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716
Attachment 34402: Patch 4 for bug 27716
https://bugs.webkit.org/attachment.cgi?id=34402&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Hot hot hot! :)
hasGeolocationProperty() is really testing "isGeolocationPropertyEnumerable" :)
13 shouldBeTrue("typeof navigator.geolocation == 'object'");
could be written as:
shouldBeEqualToString("typeof navigator.geolocation", "object");
But it looks great as is too! :)
Thanks!
More information about the webkit-reviews
mailing list