[webkit-reviews] review granted: [Bug 27543] Add platform/wince/ files for WINCE port : [Attachment 34385] 10) Cursor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 8 12:11:58 PDT 2009

Eric Seidel <eric at webkit.org> has granted Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27543: Add platform/wince/ files for WINCE port

Attachment 34385: 10) Cursor

------- Additional Comments from Eric Seidel <eric at webkit.org>
An interesting approach. :)

 41 : m_impl(other.m_impl)
 46 : m_impl(CursorNone)
 61 : m_impl(c)

Normally we don't use "get" in function names.	I might have named it
cursorForType(type) instead.

I've never seen a .cpp file use single-line function declarations like that
before.  But I also don't think it's harmful.

OK.  Please fix the indent nit on landing.

More information about the webkit-reviews mailing list