[webkit-reviews] review denied: [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists : [Attachment 33773] Updated patch with one MSVC warning fixed and explanation for the other ignored warning

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33773: Updated patch with one MSVC warning fixed and explanation for
the other ignored warning
https://bugs.webkit.org/attachment.cgi?id=33773&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
A couple of concerns and comments:
JS_EXPORTDATA is a confusing choice of name when the majority of things being
exported are functions.
There are a number of places that an entire class has been marked as being
exported even though only a single symbol is currently listed in
JavaScriptCore.exp and JavaScriptCore.def.  ByteCodeGenerator, Parser and
ParserArena are the three that jump out at me for this reason.
It's not clear why WEBKIT_EXPORTDATA exists.  It doesn't seem to be used
anywhere.