[webkit-reviews] review denied: [Bug 23642] [GTK] Drag and drop support : [Attachment 33515] Third patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 8 09:05:21 PDT 2009

Eric Seidel <eric at webkit.org> has denied Zan Dobersek <zandobersek at gmail.com>'s
request for review:
Bug 23642: [GTK] Drag and drop support

Attachment 33515: Third patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
What are the ownership semantics of this call?
	 gtk_selection_data_set(selection_data, selection_data->target, 8,
 1107				     reinterpret_cast<const
 1108				     clipboard->text().length());

I assume the clipboard makes a copy of whatever string we send to it?

Seems we could put all the string acquisition logic in the switch and follow
the switch with a single gtk_selection_data_set call.

Also, seems a bit odd to use a switch if you're returning out of each

Why use forcusedFrame instead of the passed in Frame?

What is clipboard used for in startDrag and why does the gtk code not use it?

Need more information in the ChangeLog about why we're deviating from the
expected Platform interface by ignoring the parameters in the startDrag call.

More information about the webkit-reviews mailing list