[webkit-reviews] review denied: [Bug 24887] Wrong filename when dragging an image to the Desktop. : [Attachment 34318] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 8 07:51:01 PDT 2009

Eric Seidel <eric at webkit.org> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 24887: Wrong filename when dragging an image to the Desktop.

Attachment 34318: patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
Given Oliver's comment above about what to look for on the clipboard, marking
r- while we wait for a response or test case.

I wonder if we really want the suggested filename code on HTMLImageElement. 
Seems like something that would apply for <video> and <audio> elements
eventually too, no?  Depends on what browsers chose to make the drag behavior
for these objects.  Also, I would think <svg> image elements would need this
same image code.

If you're successful in creating a test case, and add an SVG image element to
your test, I think you'll find that we "fail" the SVG image element drags after
this patch.

More information about the webkit-reviews mailing list